Skip to content

Conversation

disini
Copy link
Contributor

@disini disini commented Aug 21, 2025

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, your commit message must be modified to comply with semantic-release rules. See Conventional commits. E.g. docs: fix vtkVolumeVS.glsl module name

@disini
Copy link
Contributor Author

disini commented Aug 25, 2025

LGTM

However, your commit message must be modified to comply with semantic-release rules. See Conventional commits. E.g. docs: fix vtkVolumeVS.glsl module name

OK, I 've re-commited and re-pushed the last modification.

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul finetjul added this pull request to the merge queue Aug 28, 2025
Merged via the queue into Kitware:master with commit 4137d60 Aug 28, 2025
2 checks passed
Copy link

🎉 This PR is included in version 34.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants